create appender ext #164
Merged
create appender ext #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
create_appender_ext, which allows specifying the catalog (aka database) name. Also changecreate_appenderto support the schema being optional (null).I made a minor breaking change to the API: I reversed the order of the arguments to
createAppenderin order to make the schema and catalog names optional. This allows for simpler calls when the current database/catalog and/or default schema is desired.I changed all call sites in the tests and in the main README.
I lowered the iterations for the
readbenchmark because it was taking too long.